Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Patch bad reference to clone key variable in dockerfile/cosmos #252

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

pharr117
Copy link
Contributor

@pharr117 pharr117 commented Jun 9, 2024

Also tagging @boojamya and @johnletey for visibility (want to make sure this was the intention).

@pharr117 pharr117 requested a review from a team June 9, 2024 22:10
@pharr117 pharr117 force-pushed the pharr117/patch-clone-key-test branch from e4d7e76 to 911fbac Compare June 9, 2024 22:11
@pharr117 pharr117 changed the title patch(clone key): Patch bad reference to clone key variable in dockerfile/cosmos fix: Patch bad reference to clone key variable in dockerfile/cosmos Jun 9, 2024
@johnletey
Copy link
Contributor

@pharr117 Good catch, yes this was a mistake on our end!

Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet shellcheck would have caught this. I skimmed over the change quick and it slipped past me.

vimystic
vimystic previously approved these changes Jun 9, 2024
@vimystic
Copy link
Contributor

vimystic commented Jun 9, 2024

oops , Accidently review on my part .
I had two PRs open and reviewed the wrong one* .
Please wait for someone else to review.

@vimystic vimystic dismissed their stale review June 9, 2024 23:46

Accidental review

@agouin agouin merged commit b0b2781 into main Jun 10, 2024
6 of 7 checks passed
@agouin agouin deleted the pharr117/patch-clone-key-test branch June 10, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants